Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set up required key sessions on waitingforkey event #1232

Merged

Conversation

gesinger
Copy link
Contributor

@gesinger gesinger commented Dec 9, 2021

If a waitingforkey event is fired, try to set up new key
sessions, as the manifest may have new key information.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

If a waitingforkey event is fired, try to set up new key
sessions, as the manifest may have new key information.
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #1232 (8eb7ede) into main (f109078) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1232      +/-   ##
==========================================
+ Coverage   86.30%   86.31%   +0.01%     
==========================================
  Files          39       39              
  Lines        9797     9807      +10     
  Branches     2278     2279       +1     
==========================================
+ Hits         8455     8465      +10     
  Misses       1342     1342              
Impacted Files Coverage Δ
src/videojs-http-streaming.js 91.02% <100.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f109078...8eb7ede. Read the comment docs.

gkatsev
gkatsev previously approved these changes Dec 15, 2021
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@gesinger gesinger merged commit 3ed24a4 into videojs:main Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants